This repository was archived by the owner on Dec 18, 2022. It is now read-only.
[CI] "Fixed" macOS packaging on gh-actions#552
Closed
AnotherFoxGuy wants to merge 1 commit intotenacityteam:masterfrom
Closed
[CI] "Fixed" macOS packaging on gh-actions#552AnotherFoxGuy wants to merge 1 commit intotenacityteam:masterfrom
AnotherFoxGuy wants to merge 1 commit intotenacityteam:masterfrom
Conversation
Member
|
Many people use the artifacts as "nightly builds", which we did as a result of persistent requests by the community. The end result is still going to be "macOS artifacts may not be available, sometimes", right? Just without the ❌. |
Signed-off-by: Edgar <Edgar@AnotherFoxGuy.com>
Contributor
|
Ehh, I don't think suppressing this error is a great idea. This would set us up to easily overlook any regressions in macOS packaging. |
Member
|
#545 appears to partially or fully resolve the issue anyway, so suppressing it doesn't make sense |
Contributor
|
Reminds me of Volkswagen — the unit test defeat device. 😛 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This "fixes" the macOS packaging step by always reporting success, even when it failed
I know this isn't a proper fix, but at least the builds aren't marked as failed when the only issue is the macOS packaging
Sort of fixes #548
Checklist
-sorSigned-off-by* (See: Contributing § DCO)* indicates required